-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change from numberOfMatches() to segment number in DisplacedMuonFilterProducer #42763
Conversation
enable nano |
A new Pull Request was created by @vlimant (vlimant) for CMSSW_13_0_X. It involves the following packages:
@cmsbuild, @simonepigazzini, @jfernan2, @mandrenguyen, @vlimant can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
FYI @24LopezR |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-86a836/34717/summary.html Comparison SummarySummary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
Yes, changes are consistent with what is expected. Also, from numberOfMatches() histogram we observe an increase of muons in the region <2, which is also expected since now the filter is not acting in that region anymore for DSAs. Together with this comes a decrease in the region >=2, because there are DSAs that passed the old filter and now they fail. See comparison from WF 136.793: These are the same effects seen in #41496 |
+1 |
backport of #41496 Same comment as elsewhere, @cms-sw/orp-l2 do we backport to intermediate releases? |
type muon |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Yes, please backport to the intermediate release cycles. |
PR description:
plain backport of #41496 to 13.0.X